REF/CLN: Index.get_value wrapping incorrectly #31125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Jan 18, 2020
| @@ -815,18 +815,6 @@ def __getitem__(self, key): | |||
| try: | |||
| result = self.index.get_value(self, key) | |||
|
|
|||
| if not is_scalar(result): | |||
There was a problem hiding this comment.
can just return directly here)
There was a problem hiding this comment.
yah, we return result on the next line
| @@ -4648,19 +4649,17 @@ def get_value(self, series, key): | |||
| return libindex.get_value_at(s, key) | |||
| except IndexError: | |||
| raise | |||
| except TypeError: | |||
| # generator/iterator-like | |||
| if is_iterator(key): | |||
There was a problem hiding this comment.
do we just have no tests which hit this?
There was a problem hiding this comment.
this should be caught by the not is_scalar(key) check that we recently moved to the beginning of this method
jreback
added
the
Indexing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index.get_value isn't wrapping non-scalar results correctly, as a result of which we have an ugly kludge in
Series.__getitem__to do that wrapping. This fixes that.